This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
[CLAIM - Approve] - Tweak useApproveCallbackFromClaim + wire into app #2230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nenadV91
reviewed
Jan 20, 2022
| // Claim only approves GNO and USDC (GnoOption & Investor, respectively.) | ||
| const approveAmounts = useMemo(() => { | ||
| if (supportedChain && (claimType === ClaimType.GnoOption || claimType === ClaimType.Investor)) { | ||
| const investmentCurrency = claimTypeToToken(claimType, supportedChain) as Token |
There was a problem hiding this comment.
Just out of curiosity, could we also use claim.currencyAmount?.currency from the claim object here?
nenadV91
approved these changes
Jan 20, 2022
|
merging to consolidate branches then will rebase the base |
maria-vslvn
pushed a commit
that referenced
this pull request
Jan 25, 2022
redux-devtools-extension integration is already provided through @reduxjs/toolkit.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Wires in the new
useApproveCallbackFromClaim- which has been tweaked to better handle how the claim flow works.Testing