Show total invested vCow amount #2223
Conversation
|
| return claims.reduce<typeof zeroVCow>((totalTokens, claim) => { | ||
| const { price, currencyAmount } = claim | ||
| // if claim is included in selected invest option | ||
| if (selected.includes(claim.index)) { |
There was a problem hiding this comment.
What about free claims?
There was a problem hiding this comment.
Based on text and place, I assume this is only to show investment claims sum vCOW to receive based on selected investment(s):
|
While implementing #2227 I think this is no longer relevant. If we take the route we discussed on Figma, we won't show this value on the allowances page (without the free claims). Effort not wasted though, as I did use this PR as reference for my changes. Let's discuss with the team tomorrow to make a decision. |
|
I get a hard error when try to open the Claim page as a not connected user/connected to Mainnet/xDAI user |
|
@elena-zh Thank you Elena, should be fixed now. |
There was a problem hiding this comment.
If we take the route we discussed on Figma, we won't show this value on the allowances page (without the free claims).
Instead we'll show it on the review page, where all the data is already present.
Will just need to sum it up there directly, so this hook will be redundant.
Yes, this is also what we discussed in the last sync. I tried to suggest this in my doc of outstanding things and this message https://gnosisinc.slack.com/archives/C025G521XQD/p1642549623080200
Happy to remove the totals in the approvals page
|
Thank you, @nenadV91 ! |
Summary
Calculates and shows total amount of invested vCow on the InvestFlowStep 1
