Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Hide claim button for claiming/claimed states #2222

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Jan 19, 2022

Summary

This PR removes the claim button for all states but the DEFAULT, meaning, it will be hidden when:

  • attempting to claim
  • submitted a claim
  • confirmed a claim

It was something that was confusing users in the sessions.

Screenshot at Jan 19 18-46-02

image

To Test

  1. Do a claim of any kind
  2. Make sure the button is not present while pending or in the success page

@anxolin anxolin requested review from a team January 19, 2022 18:49
@elena-zh
Copy link

Seems that the brunch has conflicts: no preview link

@elena-zh
Copy link

I was able to verify the issue in #2227 PR: there were no buttons in 'Claiming' and 'Claimed!' screens.

@github-actions
Copy link
Contributor

  • 🔭 GP Swap: Gnosis Protocol v2 Swap UI

@elena-zh
Copy link

Retested changes in the current PR: LGTM!

@W3stside W3stside merged commit ffb70c8 into claim Jan 20, 2022
@W3stside W3stside deleted the hide-claim-button-claim branch January 20, 2022 13:59
maria-vslvn pushed a commit that referenced this pull request Jan 25, 2022
* chore: change language icon to globe
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants