Simplify error messages #2217
Simplify error messages #2217
Conversation
|
| Initial = 'Insufficient balance to cover the selected investment amount. Either modify the investment amount or unselect the investment option to move forward', | ||
| Balance = 'Insufficient balance to cover the selected investment amount, please modify the selected amount to move forward', | ||
| MaxCost = 'Selected amount is higher than available investment amount, please modify the input amount to move forward', | ||
| InsufficientBalance = 'Insufficient balance to cover the investment', |
There was a problem hiding this comment.
the investment sounds weird, I would say:
| InsufficientBalance = 'Insufficient balance to cover the investment', | |
| InsufficientBalance = 'Insufficient balance to cover investment amount', |
| Balance = 'Insufficient balance to cover the selected investment amount, please modify the selected amount to move forward', | ||
| MaxCost = 'Selected amount is higher than available investment amount, please modify the input amount to move forward', | ||
| InsufficientBalance = 'Insufficient balance to cover the investment', | ||
| SurplusMaxInvestment = `Your investment amount can't be above the maximum investment allowed`, |
There was a problem hiding this comment.
Surplus means something different to me. What about OverMaxInvestment
| @@ -22,9 +22,8 @@ import { ONE_HUNDRED_PERCENT, ZERO_PERCENT } from 'constants/misc' | |||
| import { PERCENTAGE_PRECISION } from 'constants/index' | |||
|
|
|||
| enum ErrorMsgs { | |||
| Initial = 'Insufficient balance to cover the selected investment amount. Either modify the investment amount or unselect the investment option to move forward', | |||
There was a problem hiding this comment.
We might want to tells users that they can either modify OR unselect it, which can only be done in the first screen.
Also, you can't change the amount when claiming for someone else, we should distinguish that
There was a problem hiding this comment.
We might want to tells users that they can either modify OR unselect it, which can only be done in the first screen.
Also, you can't change the amount when claiming for someone else, we should distinguish that
My thinking is that messages should be shorter and Insufficient balance to cover investment amount works for 100% investments where you don't have enough tokens, or for self claiming.
I'll ask for suggestions, not too strongly opinionated so happy to go either way as long as we keep it short.
|
Merging then, @alfetopito feel free to PR on top. |
Summary
Follow up on nenad's pr just to simplify the error messages.
Just uses the same message for the cases where you have insufficient balance. It doesn't matter if its for self account or not.
Also reduces the text, imo should be enough, and if we add too much, sometimes they don't even read 😆