Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Replace Gnosis Protocol --> CoW Protocol #2140

Merged
merged 5 commits into from
Jan 14, 2022
Merged

Replace Gnosis Protocol --> CoW Protocol #2140

merged 5 commits into from
Jan 14, 2022

Conversation

alongoni
Copy link
Contributor

@alongoni alongoni commented Jan 13, 2022 •
edited
Loading

Summary

Fixes #2119
image
image

To Test

  1. Open Swap form
  2. Connect to Gnosis chain
  3. Select token pair: WXDAI-ADAI
  4. Enter an amount.
  5. Press on the 'Read more about...' link

@alongoni alongoni added app:CowSwap CowSwap app Protofire Handled by Protofire development team labels Jan 13, 2022
@alongoni alongoni self-assigned this Jan 13, 2022
@alongoni alongoni added Medium Severity indicator. It causes some undesirable behavior, but the system is still functional Bug Something isn't working labels Jan 13, 2022
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: Gnosis Protocol v2 Swap UI

@alongoni alongoni marked this pull request as ready for review January 13, 2022 20:16
@alongoni
Merge remote-tracking branch 'refs/remotes/origin/2119-gnosis-protoco…
4117934 
…l-to-cow-protocol' into 2119-gnosis-protocol-to-cow-protocol
alongoni
alongoni commented Jan 13, 2022
View reviewed changes
src/custom/api/gnosisProtocol/api.ts
@@ -73,7 +73,7 @@ const DEFAULT_HEADERS = {
'Content-Type': 'application/json',
'X-AppId': APP_DATA_HASH.toString(),
}
const API_NAME = 'Gnosis Protocol'
const API_NAME = 'CoW Protocol'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about this change, maybe it can cause any problem?

Copy link
Contributor

@henrypalacios henrypalacios Jan 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, that variable is used for messages.

@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

W3stside
W3stside approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@W3stside W3stside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fine, thanks!

elena-zh
elena-zh approved these changes Jan 14, 2022
View reviewed changes
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

henrypalacios
henrypalacios approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@henrypalacios henrypalacios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job!

@alongoni alongoni added the Auto-merge PRs with this tag will be automatically merged when approved and CI succeeds label Jan 14, 2022
@mergify mergify bot merged commit 9899670 into develop Jan 14, 2022
@alfetopito alfetopito deleted the 2119-gnosis-protocol-to-cow-protocol branch January 14, 2022 15:25
anxolin
anxolin reviewed Jan 16, 2022
View reviewed changes
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE

nenadV91 pushed a commit that referenced this pull request Jan 17, 2022
@alongoni @nenadV91
Replace Gnosis Protocol --> CoW Protocol (#2140)
c9a9d36 
# Summary

Fixes #2119
![image](https://user-images.githubusercontent.com/622217/149398774-6088aa29-5e89-4e8d-8dbc-912fa44a4161.png)
![image](https://user-images.githubusercontent.com/622217/149398844-fab60805-3f9d-49c9-8b0d-bce96034e9c6.png)


  # To Test

1. Open Swap form
2. Connect to Gnosis chain
3. Select token pair: WXDAI-ADAI
4. Enter an amount.
5. Press on the 'Read more about...' link
@alfetopito alfetopito mentioned this pull request Jan 25, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anxolin anxolin anxolin left review comments

@henrypalacios henrypalacios henrypalacios approved these changes

@W3stside W3stside W3stside approved these changes

@elena-zh elena-zh elena-zh approved these changes

@ramirotw ramirotw Awaiting requested review from ramirotw

Assignees

@alongoni alongoni

Labels
app:CowSwap CowSwap app Auto-merge PRs with this tag will be automatically merged when approved and CI succeeds Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional Protofire Handled by Protofire development team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1.8.1] 'Gnosis protocol' is not changed to CoW Protocol for 'Unsupported token' message
6 participants
@alongoni @anxolin @henrypalacios @W3stside @elena-zh @lint-action