Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

[Claim] - Mod useUserHasSubmittedClaim #2133

Merged
merged 3 commits into from
Jan 13, 2022
Merged

Conversation

W3stside
Copy link
Contributor

Summary

Mods useUserHasSubmittedClaim as the original (in use) depends on a different state shape. Now works to show Claiming vCow... with our setup

Known caveats: we can have multiple claims, this will show up if ANY claim exists where claim recipient === account connected. Should it show only if ALL are being claimed? or should we show sth different?

Screenshots:

Screenshot 2022-01-13 at 14 45 56

To Test:

  1. connect via 0x97EC4fcD5F78cA6f6E4E1EAC6c0Ec8421bA518B7 rinkeby
  2. in console, do: addMockClaimTransactions([14890])
  3. To clear, delete console > applications > localstorage

@W3stside W3stside requested review from a team January 13, 2022 14:51
Base automatically changed from claim-pending-update to claim-pending January 13, 2022 14:52
@W3stside
Copy link
Contributor Author

will merge early @gnosis/gp-frontend - please post merge review, this code is minor.

@github-actions
Copy link
Contributor

  • 🔭 GP Swap: Gnosis Protocol v2 Swap UI

@W3stside W3stside merged commit f920236 into claim-pending Jan 13, 2022
@W3stside W3stside deleted the claim-fix-claim-hook branch January 13, 2022 15:07
Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alfetopito
Copy link
Contributor

I think it's fine to show like you did, once there's any pending claim.
We don't want to detail all the pending claims in that button, for more details user should just check the claim page.

fairlighteth pushed a commit that referenced this pull request Jan 14, 2022
* update @uniswap/sdk-core and @uniswap/v3-sdk

* reorder
anxolin pushed a commit to anxolin/cowswap that referenced this pull request Apr 1, 2022
* update @uniswap/sdk-core and @uniswap/v3-sdk

* reorder

Co-authored-by: Justin Domingue <judo@uniswap.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants