-
Notifications
You must be signed in to change notification settings - Fork 55
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Light approve.
My initial thinking was that i was not sure if we wanted to do this. It was not part of the initial plan at least. Since it's done, we can leave it, but this will require someone to style the profile a bit better.
The whole profile could use a bit of redesign, but im happy if at least we present the balance and claimable balance a bit better and we keep in mind to do a deeper redesign at a later point.
I think, the idea is great to show a user an amount of available to claim tokens. Getting back to the current implementation, I agree on the point that the UI looks a bit horrible. |
Everything that's still claimable summed up. Includes both airdrop and investment opportunities, given that their time windows are still open.
Yeah, that's what I meant :D |
Of course, styling to be done for sure - if we decided to keep this. As for why, this is a compromise for not showing the value on top and for showing the vCOW balance on this page. What I mean is:
Code wise, it's ready. Style wise of course not. Is this reasoning strong enough to justify it? |
553a21c
to
f5a4d09
Compare
* set language using url param in language dropdown * refactor common code into a hook * add hook * address pr feedback
sure :) if this doens't add to much distraction, im up for it 👌 |
@alfetopito i change your base branch to develop |
I'm leaving this on-hold until the other stuff is ready |
Let's not go with this |
Summary
Depends on #2062
Shows Claimable amount on Profile page
To Test
0xdd0cd0b5ab9055ca8b4ac7fcc6c54d179f38e9c9f59b52d22b4022fbb672187a
Note horrible styled, meant to only connect the dots. Styling work desperately needed