This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
[2002 - return Fee data to UI] - Show fee amount when SellAmountDoesNotCoverFee #2039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
alfetopito
approved these changes
Dec 23, 2021
nenadV91
pushed a commit
that referenced
this pull request
Jan 3, 2022
* upgrade to 7.0 * first iteration of stubbing subgraph in integration tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2002
Previously, the different fee endpoint would return fee data regardless of whether the sell amount was enough to cover the fee (it didn't even throw, really)
New quote endpoint now returns that data as well as part of a
dataprop.Seen working:
Testing
dataprop with fee info