Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Incorrect validation message when claim amount is too low, and number of decimals > required #2274

Closed
elena-zh opened this issue Jan 24, 2022 · 1 comment
Labels
app:CowSwap CowSwap app Bug Something isn't working Claim Issues related to 'Claim' feature Low Severity indicator for defects. It won't cause any major break-down of the system

Comments

@elena-zh
Copy link

Select investment option USDC to claim
Enter too low amount 0.000000001 (with 9 decimals)
For ETH/GNO option enter an amount with 19 decimals (0.0000000000000000001)

AR: 'Your investment amount can't be zero' validation message
image.png

ER: I'd expect 'Enter a valid amount' or so as the validation message for this case

@elena-zh elena-zh added app:CowSwap CowSwap app Claim Issues related to 'Claim' feature Low Severity indicator for defects. It won't cause any major break-down of the system Bug Something isn't working labels Jan 24, 2022
@anxolin
Copy link
Contributor

anxolin commented Jan 26, 2022

well, true, we could limit for the precision of the token, although i think is super low prio.

The case affects just the warning message of users who try to add 19 decimals for ether and 7 decimals for USDC. And not even that, we allow it as long as its over one wei in the unit.

Closing cause its not worth the effort imo. Re-open if you think is imp

@anxolin anxolin closed this as completed Jan 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
app:CowSwap CowSwap app Bug Something isn't working Claim Issues related to 'Claim' feature Low Severity indicator for defects. It won't cause any major break-down of the system
Projects
None yet
Development

No branches or pull requests

2 participants