Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Scroll on the Swap page when screen resolution is 1536 x 864 and less #1276

Closed
elena-zh opened this issue Aug 18, 2021 · 0 comments · Fixed by #2488 or #2523
Closed

Scroll on the Swap page when screen resolution is 1536 x 864 and less #1276

elena-zh opened this issue Aug 18, 2021 · 0 comments · Fixed by #2488 or #2523
Assignees
Labels
app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system Protofire Handled by Protofire development team

Comments

@elena-zh
Copy link

When I open swap page in the desktop version when screen resolution is 1536 x 864 and less, I see a scroll bar. However, there is a plenty room on the page.
Sometimes, scroll disappears when I close a banner notification (this is in Chrome and Brave):
https://drive.google.com/file/d/1RPxrer7jSZ2atTnM4Zp3OuySJM27SVeb/view

Sometimes closing notification bar does not help
https://drive.google.com/file/d/1Prxfwere0IhlrhNmRHImdNl3eelqOAAI/view

Expected: do not show scrollbar in the Swap page in a default state

@elena-zh elena-zh added app:CowSwap CowSwap app Low Severity indicator for defects. It won't cause any major break-down of the system Bug Something isn't working labels Aug 18, 2021
@elena-zh elena-zh added the Protofire Handled by Protofire development team label Dec 23, 2021
@maria-vslvn maria-vslvn self-assigned this Jan 6, 2022
@alongoni alongoni assigned alongoni and unassigned maria-vslvn Feb 10, 2022
@mergify mergify bot closed this as completed in #2488 Feb 25, 2022
mergify bot pushed a commit that referenced this issue Feb 25, 2022
mergify bot pushed a commit that referenced this issue Mar 4, 2022
# Summary
(Some [changes where made again](670ecf3) when the release v1.11.0-RC.0 was merged. )

Fixes #1276, #1550 and #2502 (new issue)

The layout has changed a bit. Some small resolutions now have less padding on top but the scroll not appear. 
Before (on production with scroll):
![image](https://user-images.githubusercontent.com/622217/155407501-f8b8778f-b962-46ec-b2d6-45354719ac7a.png)
![image](https://user-images.githubusercontent.com/622217/155407577-ce3dacf1-14f0-43a6-b452-dd6c6409e567.png)

After (on this PR without scroll):
![image](https://user-images.githubusercontent.com/622217/155407452-2fb96a92-a7f0-4a69-92ce-2ac79b11e4b5.png)
![image](https://user-images.githubusercontent.com/622217/155407640-00510b39-2190-4f50-8d6e-95cefd567599.png)

  # To Test

1. <<Step one>> Open the page [`Swap`](https://pr2523--gpswapui.review.gnosisdev.com/)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system Protofire Handled by Protofire development team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants