Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AcceptContentTypes per source, Fix isValidJson issue with arrays #206

Merged
merged 6 commits into from
Aug 31, 2023

Conversation

valentinedwv
Copy link
Member

Preps for JSON Profiles, by setting up acceptcontenttype and jsonprfile properties on sources

fixes the if is array is valid JSON issue.

Does not fix the need that like aquadocs we may need to split these things up into individual files.

Prep for json profiles #163
Prep for json profiles #163
Prep for json profiles #163
#128. For Validation just unmarshal an interface
@valentinedwv valentinedwv requested a review from fils May 3, 2023 00:54
Prep for json profiles #163
#128. For Validation just unmarshal an interface
@valentinedwv valentinedwv marked this pull request as draft May 3, 2023 02:05
@valentinedwv
Copy link
Member Author

There is a lot more going on. in this bucket..
one empyt that makes it in, (sort by size)
some are graph, with others are flattened.

Prep for json profiles #163
#128. For Validation just unmarshal an interface
Prep for json profiles #163
#128. For Validation just unmarshal an interface
@fils
Copy link
Member

fils commented Jun 14, 2023

@valentinedwv I know this is just as draft but I tested this against one of my sources with the "array graph" format and it worked perfect. Thanks!

I need to get my prov stuff fixed up and merged into dev.

At that point it might be nice to have a session and merge things into master again.

@valentinedwv valentinedwv marked this pull request as ready for review August 31, 2023 17:31
@valentinedwv valentinedwv merged commit 256a703 into dev Aug 31, 2023
@valentinedwv valentinedwv deleted the dev_dv_192_jsonprofiles branch September 8, 2023 22:32
@valentinedwv valentinedwv restored the dev_dv_192_jsonprofiles branch June 17, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants