Parse attribute syntax #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey folks! Is there anything blocking merging and releasing these? |
|
@the-mikedavis Agreed, I'm going to take care of a few items now. I'd like to sequence the updates in an order that makes sense and cut relevant releases. As for the integration tests, I'm going to undo the dropping of |
J3RN
force-pushed
the
main
branch
3 times, most recently
from
5eb3653
to
8302c98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #60.
I didn't add a requirement that attributes preceed imports or functions but I think it's probably ok if we're a little more permissive about that. I'm happy to add some extra checks if that's desired though.