String pattern alias #2295
Merged
String pattern alias #2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giacomocavalieri
force-pushed
the
string-pattern-alias
branch
2 times, most recently
from
a65d40c
to
5660168
Compare
|
Hi @giacomocavalieri ! Would you like me to pick this work? |
giacomocavalieri
force-pushed
the
string-pattern-alias
branch
from
5660168
to
eaa8b7a
Compare
|
@lpil sorry if it took me quite some time, I think the PR is ready for review now 👍 |
lpil
reviewed
Sep 7, 2023
| @@ -676,6 +693,7 @@ impl ValueConstructor { | |||
| pub(crate) fn get_documentation(&self) -> Option<&str> { | |||
| match &self.variant { | |||
| ValueConstructorVariant::LocalVariable { .. } => Some("A locally defined variable."), | |||
| ValueConstructorVariant::LocalConstant { .. } => Some("A locally defined constant."), | |||
There was a problem hiding this comment.
Suggested change
| ValueConstructorVariant::LocalConstant { .. } => Some("A locally defined constant."), | |
| ValueConstructorVariant::LocalConstant { .. } => Some("A locally defined variable."), |
This is an implementation detail of the compiler, it's still a regular variable from the user's point of view.
lpil
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #2294 and #2243