Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set BLE power after connection is established. #77

Merged
merged 1 commit into from
Mar 10, 2024
Merged

Set BLE power after connection is established. #77

merged 1 commit into from
Mar 10, 2024

Conversation

gkoh
Copy link
Owner

@gkoh gkoh commented Mar 10, 2024

As per the ESP32 docs, set the BLE power after we have established the connection.
Whilst here, refactor the handling so 'Scan::init()' sets the power before setup and 'Camera::connect()' sets the power after success.

@gkoh
Set BLE power after connection is established.
be88a19 
As per the ESP32 docs, set the BLE power _after_ we have established the
connection.
Whilst here, refactor the handling so 'Scan::init()' sets the power
before setup and 'Camera::connect()' sets the power after success.
@gkoh gkoh linked an issue Mar 10, 2024 that may be closed by this pull request
M5StickC Plus range seems lower than M5StickC #75
Closed
@gkoh
Copy link
Owner Author

gkoh commented Mar 10, 2024

@matthudsonau See if this makes any difference.
My testing has been super unscientific, but seems to make my M5StickC and Plus reach similar shutter control distance.

@matthudsonau
Copy link
Contributor

@matthudsonau See if this makes any difference. My testing has been super unscientific, but seems to make my M5StickC and Plus reach similar shutter control distance.

Seems better, but I'm also doing it unscientifically. Can reliably take photos from the other end of the house now, so it's definitely improved

@gkoh
Copy link
Owner Author

gkoh commented Mar 10, 2024

@matthudsonau See if this makes any difference. My testing has been super unscientific, but seems to make my M5StickC and Plus reach similar shutter control distance.

Seems better, but I'm also doing it unscientifically. Can reliably take photos from the other end of the house now, so it's definitely improved

2 out of 2 people say it's good, considering it fixed then :)

@gkoh gkoh merged commit 51cc1e4 into master Mar 10, 2024
6 checks passed
@gkoh gkoh deleted the 75-m5stickc-plus-range-seems-lower-than-m5stickc branch March 10, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

M5StickC Plus range seems lower than M5StickC
2 participants
@gkoh @matthudsonau