Java Academy

CodeSmell & Refactoring

Authors

• Francesco
• Arber
• Giulio: @giuliocaccin

Example

The following example is the base for the refactoring exercise.

1. Create a Java 8 Maven project

2. Copy the following class

3. Let's start

    class Bottles
    {    
        public static void main(String args[])
        {
            String s = "s";
            for (int beers=99; beers>-1;beers--)
            {
                System.out.print(beers + " bottle" + s + " of beer on the wall,");
                System.out.println(beers + " bottle" + s + " of beer,");
                if (beers==0)
                {
                    System.out.print("Go to the store, buy some more,");
                    System.out.println("99 bottles of beer on the wall.\r\n");
                    return;
                }
                else
                    System.out.print("Take one down, pass it around,");
                s = (beers-1 == 1)?"":"s";
                System.out.println(beers-1 + " bottle" + s + " of beer on the wall.\r\n");
            }
        }
   

   }

4. Stream and file reading examples

	final ByteArrayOutputStream stream = new ByteArrayOutputStream();
	Bottles.writeLyrics(new PrintStream(stream));
	final String actual = new String(stream.toByteArray());
	final String expected = new String(Files.readAllBytes(Paths.get("src/main/resources/golden_master.txt")));
	Assert.assertEquals(expected, actual);

Presentation

The presentation is hosted on gitpitch at the following link: http://gitpitch.com/giuliocaccin/javaAcademy/pitch