Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Directionality into MCF #8

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Adding Directionality into MCF #8

wants to merge 18 commits into from

Conversation

ntalluri
Copy link
Collaborator

No description provided.

@ntalluri
Copy link
Collaborator Author

ntalluri commented Jan 2, 2024

for graph 3 and 7, I was expected the same edges to be on the output, but that did not happen. *reminder to see why later

@ntalluri
Copy link
Collaborator Author

ntalluri commented Jan 17, 2024

with the updates to the code, graph 3 and 7 are still not the same. I think at this point, I think the solver may be doing something behind the scenes.

@agitter
Copy link
Member

agitter commented Jan 24, 2024

Let's make a v0.1 release before merging this so that this version of MCF can become v0.2. That will make it easier for the Dockerfile in SPRAS to refer to versioned releases of this code.

@ntalluri
Copy link
Collaborator Author

Ready for code review

Copy link
Member

@agitter agitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finally starting reviewing these changes. I only looked at the code changes so far. I would like to run the updated version locally and inspect all the test graphs before merging.

.DS_Store Outdated Show resolved Hide resolved
minCostFlow.py Show resolved Hide resolved
minCostFlow.py Outdated Show resolved Hide resolved
minCostFlow.py Show resolved Hide resolved
minCostFlow.py Outdated Show resolved Hide resolved
minCostFlow.py Outdated Show resolved Hide resolved
test_minCostFlow.py Outdated Show resolved Hide resolved
@ntalluri
Copy link
Collaborator Author

Ready for code review again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants