Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add monospace font to Code Examples #4

Closed
giovaninppc opened this issue Sep 23, 2022 · 3 comments · Fixed by #9
Closed

Add monospace font to Code Examples #4

giovaninppc opened this issue Sep 23, 2022 · 3 comments · Fixed by #9
Assignees
@giovaninppc
Labels
enhancement New feature or request

Comments

@giovaninppc
Copy link
Owner

  • I believe it would be much better to read the code with a monospaced font
  • And... maybe take a look into syntax highlight?
@giovaninppc giovaninppc added the enhancement New feature or request label Sep 23, 2022
@giovaninppc
Copy link
Owner Author

I've simply added the monospace modifier to the system font - that I didn't know existed
Screen Shot 2022-09-24 at 12 02 17

Also, adding a scroll capability to the code view - when breaking the line it was getting super hard to understand what was going on

@giovaninppc giovaninppc self-assigned this Sep 24, 2022
@giovaninppc
Copy link
Owner Author

I was looking int o using Sourceful for the syntax highlight, but the view kept breaking and I couldn't figure why, so I made a new highlighter based in multiple regexes.

It should be enough for the project for now, and if we do find any issues we can make changes on it or even replacing with something better.

@giovaninppc
Copy link
Owner Author

Screen Shot 2022-09-24 at 13 23 50

@giovaninppc giovaninppc mentioned this issue Sep 24, 2022
Merged
@giovaninppc giovaninppc linked a pull request Sep 24, 2022 that will close this issue
[#4] Added manual code syntax highlight and monospaced font #9
Merged
giovaninppc added a commit that referenced this issue Sep 24, 2022
@giovaninppc
Merge pull request #9 from giovaninppc/issue/4-monospaced-font
5f1a0a7 
[#4] Added manual code syntax highlight and monospaced font
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@giovaninppc giovaninppc

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#4] Added manual code syntax highlight and monospaced font giovaninppc/AccessibilityHandbook
1 participant
@giovaninppc