Skip to content

Commit

Permalink
Bom 1.8.1
Browse files Browse the repository at this point in the history
  • Loading branch information
giovaninppc committed Jan 5, 2023
1 parent 2ab2ab0 commit e2eb425
Show file tree
Hide file tree
Showing 6 changed files with 30 additions and 7 deletions.
8 changes: 4 additions & 4 deletions Accessibility Handbook.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -1487,7 +1487,7 @@
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
ASSETCATALOG_COMPILER_GLOBAL_ACCENT_COLOR_NAME = AccentColor;
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 5;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_ASSET_PATHS = "\"Accessibility Handbook/Preview Content\"";
DEVELOPMENT_TEAM = "";
ENABLE_PREVIEWS = YES;
Expand All @@ -1501,7 +1501,7 @@
"$(inherited)",
"@executable_path/Frameworks",
);
MARKETING_VERSION = 1.8.0;
MARKETING_VERSION = 1.8.1;
PRODUCT_BUNDLE_IDENTIFIER = Handbook;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_EMIT_LOC_STRINGS = YES;
Expand All @@ -1516,7 +1516,7 @@
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
ASSETCATALOG_COMPILER_GLOBAL_ACCENT_COLOR_NAME = AccentColor;
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 5;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_ASSET_PATHS = "\"Accessibility Handbook/Preview Content\"";
DEVELOPMENT_TEAM = "";
ENABLE_PREVIEWS = YES;
Expand All @@ -1530,7 +1530,7 @@
"$(inherited)",
"@executable_path/Frameworks",
);
MARKETING_VERSION = 1.8.0;
MARKETING_VERSION = 1.8.1;
PRODUCT_BUNDLE_IDENTIFIER = Handbook;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_EMIT_LOC_STRINGS = YES;
Expand Down
13 changes: 13 additions & 0 deletions Accessibility Handbook/AboutTheApp/WhatsNewView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ struct WhatsNewView: View, Page {
VStack(alignment: .leading, spacing: .regular) {
ScrollView([.vertical], showsIndicators: false) {
currentVersion
v1_8_1
v1_8_0
v1_7_0
v1_6_0
Expand All @@ -25,6 +26,7 @@ struct WhatsNewView: View, Page {
v1_1_0
}
}
.navigationTitle(title)
.padding(.horizontal)
}
}
Expand All @@ -37,6 +39,17 @@ private extension WhatsNewView {
}
}

@ViewBuilder
private var v1_8_1: some View {
release(
version: "1.8.1",
description: L10n.WhatsNew._181.description,
pages: [
GroupingPage()
]
)
}

@ViewBuilder
private var v1_8_0: some View {
release(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ private extension GroupingPage {
private extension GroupingPage {
var containedCarousel: some View {
VStack(alignment: .leading, spacing: .large) {
Title(L10n.Grouping.goodCarousel)
Title(L10n.Grouping.containedCarousel)
ScrollView(.horizontal, showsIndicators: false) {
HStack(spacing: .large) {
ForEach(1...5, id: \.self) { _ in
Expand Down
6 changes: 6 additions & 0 deletions Accessibility Handbook/Strings/Strings.swift
Original file line number Diff line number Diff line change
Expand Up @@ -1536,6 +1536,8 @@ internal enum L10n {
internal static let cellTitle = L10n.tr("Localizable", "Grouping.cellTitle")
/// This may seem obvious, but can be easily forgotten on development.
internal static let comment = L10n.tr("Localizable", "Grouping.comment")
/// Grouped (contain) Carousel
internal static let containedCarousel = L10n.tr("Localizable", "Grouping.containedCarousel")
/// Grouped Carousel
internal static let goodCarousel = L10n.tr("Localizable", "Grouping.goodCarousel")
/// To me, Grouping elements correctly is one of the most important parts of building a good accessible view.
Expand Down Expand Up @@ -3187,6 +3189,10 @@ internal enum L10n {
/// Introducing: Classes!\nOur new update with content about how to think accessibility while implementing, with tools examples, code, diagrams... We're trying to give more content not only on what the accessibility features and options are, but also how to identify where to use them. It's really nice, take a look!
internal static let description = L10n.tr("Localizable", "WhatsNew.1_8_0.description")
}
internal enum _181 {
/// New content on Grouping elements, and some improvements to our classes!
internal static let description = L10n.tr("Localizable", "WhatsNew.1_8_1.description")
}
}

internal enum WhereIsMyContent {
Expand Down
3 changes: 3 additions & 0 deletions Accessibility Handbook/Strings/en.lproj/Localizable.strings
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@

"WhatsNew.1_8_0.description" = "Introducing: Classes!\nOur new update with content about how to think accessibility while implementing, with tools examples, code, diagrams... We're trying to give more content not only on what the accessibility features and options are, but also how to identify where to use them. It's really nice, take a look!";

"WhatsNew.1_8_1.description" = "New content on Grouping elements, and some improvements to our classes!";

// Using

"UsingTheVoiceOver" = "Using VoiceOver";
Expand Down Expand Up @@ -689,6 +691,7 @@
"Grouping.text3" = "Turn VoiceOver on and check both carousels below, one has the content correctly grouped, and the other don't.";

"Grouping.goodCarousel" = "Grouped Carousel";
"Grouping.containedCarousel" = "Grouped (contain) Carousel";
"Grouping.badCarousel" = "Ungrouped Carousel";
"Grouping.cellTitle" = "Cell title";
"Grouping.cellContent" = "Cell content";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -689,8 +689,9 @@
"Grouping.comment" = "Pode parece óbvio, mas é fácil de esquecer desse ponto durante o desenvolvimento.";
"Grouping.text3" = "Ligue o VoiceOver e foque nos dois carrosséis abaixo, um tem o conteúdo das células corretamente agrupado e o outro não.";

"Grouping.goodCarousel" = "Carrossel Bom";
"Grouping.badCarousel" = "Carrossel ruim";
"Grouping.goodCarousel" = "Carrossel Agrupado";
"Grouping.containedCarousel" = "Carrossel Agrupado (contain)";
"Grouping.badCarousel" = "Carrossel Desagrupado";
"Grouping.cellTitle" = "Título";
"Grouping.cellContent" = "Conteúdo";
"Grouping.cellComment" = "Comentário";
Expand Down

0 comments on commit e2eb425

Please sign in to comment.