Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stride for GCR initialization #1656

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Fix stride for GCR initialization #1656

merged 1 commit into from
Jul 30, 2024

Conversation

upsj
Copy link
Member

@upsj upsj commented Jul 30, 2024

Noticed by @nbeams, the GCR initialization kernel uses an incorrect stride. This fixes it and adds a test for the behavior.

@upsj upsj added the 1:ST:ready-for-review This PR is ready for review label Jul 30, 2024
@upsj upsj requested a review from a team July 30, 2024 07:54
@upsj upsj self-assigned this Jul 30, 2024
@ginkgo-bot ginkgo-bot added mod:cuda This is related to the CUDA module. type:solver This is related to the solvers mod:hip This is related to the HIP module. labels Jul 30, 2024
yhmtsai
yhmtsai approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@yhmtsai yhmtsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nbeams good catch!
Just to be clear, assuming that b and residual have the same stride leads the issue, right?

@upsj
Copy link
Member Author

upsj commented Jul 30, 2024

@yhmtsai exactly, the residual uses the default stride, while b can have an arbitrary stride

@upsj upsj added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels Jul 30, 2024
@upsj upsj merged commit a4f1335 into develop Jul 30, 2024
9 of 14 checks passed
@upsj upsj deleted the gcr_stride branch July 30, 2024 20:14
@ginkgo-bot
Copy link
Member

Error: PR already merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pratikvn pratikvn pratikvn approved these changes

@MarcelKoch MarcelKoch MarcelKoch approved these changes

@yhmtsai yhmtsai yhmtsai approved these changes

Assignees

@upsj upsj

Labels
1:ST:ready-to-merge This PR is ready to merge. mod:cuda This is related to the CUDA module. mod:hip This is related to the HIP module. type:solver This is related to the solvers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@upsj @ginkgo-bot @pratikvn @MarcelKoch @yhmtsai