Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging batch-dpcpp into batch-develop #1298

Closed
wants to merge 140 commits into from
Closed

Merging batch-dpcpp into batch-develop #1298

wants to merge 140 commits into from

Conversation

phu0ngng
Copy link

@phu0ngng phu0ngng commented Mar 14, 2023 •
edited
Loading

  • Matrix:

    • batch_csr_kernels
    • batch_dense_kernels
    • batch_ell_kernels
    • batch_diagonal_kernels

  • Preconditioner:

    • batch_identity
    • batch_scalar_jacobi
    • batch_block_jacobi: implemented, did not pass any tests, thus marked as NOT_IMPLEMENTED. There is an issue that the warp_size should be equal to block_size but the smallest possible warp_size in dpcpp is 16 which is pretty big for a batch kernel.
    • batch_ilu
    • batch_ilu_isai
    • batch_isai

  • Solver:

    • batch_cg_kernels
    • batch_bicgstab_kernels
    • batch_gmres_kernels
    • batch_direct_kernels
    • batch_idr_kernels
    • batch_richardson_kernels
    • batch_lower_trs_kernels
    • batch_upper_trs_kernels.

@phu0ngng phu0ngng requested a review from pratikvn March 14, 2023 14:36
@ginkgo-bot ginkgo-bot added reg:build This is related to the build system. mod:core This is related to the core module. type:solver This is related to the solvers type:preconditioner This is related to the preconditioners type:matrix-format This is related to the Matrix formats type:factorization This is related to the Factorizations type:stopping-criteria This is related to the stopping criteria mod:dpcpp This is related to the DPC++ module. labels Mar 14, 2023
@pratikvn
Copy link
Member

format!

@pratikvn pratikvn added 1:ST:do-not-merge Please do not merge PR this yet. 1:ST:no-changelog-entry Skip the wiki check for changelog update labels Mar 14, 2023
@pratikvn pratikvn force-pushed the batch_dpcpp branch 2 times, most recently from 2808f12 to ddc7964 Compare May 4, 2023 18:14
@phu0ngng
Copy link
Author

format!

1 similar comment
@phu0ngng
Copy link
Author

format!

@phu0ngng
Copy link
Author

format-rebase!

phu0ngng and others added 21 commits October 15, 2023 21:51
@phu0ngng @pratikvn
added case 0 for batch cg
d7cbd0c
@phu0ngng @pratikvn
rm n_shared templating for batch_gmres
6a00f2e
@phu0ngng @pratikvn
rm time print
6e03daf
@pratikvn
temp: commented out templating in batch gmres
ca819d3
@pratikvn
added large test for batch cg
d29044e
@pratikvn
cuda: added n_shared template for batch_cg and batch_bicgstab
cdcd35c
@pratikvn
fixed raw_free mem issue
f71c98e
@pratikvn
cuda: cleaning
0affb43
@pratikvn
add pele/sundials matrices
0abd4e1
@phu0ngng @pratikvn
enabled tests
362445b
@phu0ngng @pratikvn
changed nreps batched-solver.cpp
f150acd
@phu0ngng @pratikvn
added check prec_storage != 0
26ab22a
@phu0ngng @pratikvn
changes batched-solver-from-files to print only time in msec
103143e
@phu0ngng @pratikvn
optimized work-group selection
1602c9d
@phu0ngng @pratikvn
added test scripts
6d71332
@phu0ngng @pratikvn
renamed get_group_size func, and rewrite 1 0 into true false
292bc07
@phu0ngng @pratikvn
formatted
94623a6
@pratikvn
added gmres with n_shared templating
b39b740
@pratikvn
changed alignment to 2
487d7b1
@pratikvn
added a large test case for batch_gmres
1f81ab6
@ginkgo-bot @phu0ngng @pratikvn
Format files
a5654c9 
Co-authored-by: Phuong Nguyen <phu0ngng@users.noreply.github.com>
@ginkgo-bot
Copy link
Member

Error: The following files need to be formatted:

dpcpp/preconditioner/batch_jacobi_kernels.dp.cpp

You can find a formatting patch under Artifacts here or run format! if you have write access to Ginkgo

@pratikvn
Copy link
Member

Closing as it is not necessary anymore.

@pratikvn pratikvn closed this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pratikvn pratikvn Awaiting requested review from pratikvn

Assignees
No one assigned
Labels
1:ST:do-not-merge Please do not merge PR this yet. 1:ST:no-changelog-entry Skip the wiki check for changelog update mod:core This is related to the core module. mod:dpcpp This is related to the DPC++ module. reg:build This is related to the build system. type:factorization This is related to the Factorizations type:matrix-format This is related to the Matrix formats type:preconditioner This is related to the preconditioners type:solver This is related to the solvers type:stopping-criteria This is related to the stopping criteria
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phu0ngng @pratikvn @ginkgo-bot