Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MC64 #1120

Merged
merged 27 commits into from
Nov 6, 2023
Merged

Add MC64 #1120

merged 27 commits into from
Nov 6, 2023

Commits on Nov 6, 2023

  1. Add first MC64 kernels and test examples

    @fritzgoebel @upsj
    fritzgoebel authored and upsj committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    aa8269e View commit details
    Browse the repository at this point in the history

  2. First working implementation of the permutation part of MC64

    @fritzgoebel @upsj
    fritzgoebel authored and upsj committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    c6f8575 View commit details
    Browse the repository at this point in the history

  3. Add computation of scaling coefficients

    @fritzgoebel @upsj
    fritzgoebel authored and upsj committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    e5f8f3e View commit details
    Browse the repository at this point in the history

  4. tune to match HSL performance

    @fritzgoebel @upsj
    fritzgoebel authored and upsj committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    4a5275a View commit details
    Browse the repository at this point in the history

  5. Fix reference kernel tests to current version

    @fritzgoebel @upsj
    fritzgoebel authored and upsj committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    cc73332 View commit details
    Browse the repository at this point in the history

  6. Add more tests

    @fritzgoebel @upsj
    fritzgoebel authored and upsj committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    fd9a45b View commit details
    Browse the repository at this point in the history

  7. Small fix after rebasing

    @fritzgoebel @upsj
    fritzgoebel authored and upsj committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    e1c6fdb View commit details
    Browse the repository at this point in the history

  8. Format files 

    Co-authored-by: fritzgoebel <fritzgoebel@users.noreply.github.com>
    @ginkgo-bot @fritzgoebel @upsj
    2 people authored and upsj committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    8cc4139 View commit details
    Browse the repository at this point in the history

  9. work on reference kernel tests

    @fritzgoebel @upsj
    fritzgoebel authored and upsj committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    5844503 View commit details
    Browse the repository at this point in the history

  10. fix typo

    @fritzgoebel @upsj
    fritzgoebel authored and upsj committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    29a1aff View commit details
    Browse the repository at this point in the history

  11. Address review comments

    @fritzgoebel @upsj
    fritzgoebel authored and upsj committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    275473e View commit details
    Browse the repository at this point in the history

  12. update Copyright statement

    @fritzgoebel @upsj
    fritzgoebel authored and upsj committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    5619aa0 View commit details
    Browse the repository at this point in the history

  13. Fix rebasing error

    @fritzgoebel @upsj
    fritzgoebel authored and upsj committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    409c550 View commit details
    Browse the repository at this point in the history

  14. make MC64 core functionality

    @upsj
    upsj committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    ffdf820 View commit details
    Browse the repository at this point in the history

  15. review updates

    @upsj
    upsj committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    e176907 View commit details
    Browse the repository at this point in the history

  16. optimize addressable PQ for MC64

    @upsj
    upsj committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    eadd636 View commit details
    Browse the repository at this point in the history

  17. fix test

    @upsj
    upsj committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    61e0311 View commit details
    Browse the repository at this point in the history

  18. fix libstdc++ build issues

    @upsj
    upsj committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    b1557d1 View commit details
    Browse the repository at this point in the history

  19. review updates 

    Co-authored-by: Thomas Grützmacher <thomas.gruetzmacher@kit.edu>
    @upsj
    upsj and Thomas Grützmacher committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    600f599 View commit details
    Browse the repository at this point in the history

  20. Format files 

    Co-authored-by: Tobias Ribizel <upsj@users.noreply.github.com>
    @ginkgo-bot @upsj
    ginkgo-bot and upsj committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    641404f View commit details
    Browse the repository at this point in the history

  21. fix linking errors

    @upsj
    upsj committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    acca703 View commit details
    Browse the repository at this point in the history

  22. review updates 

    - use degree instead of log2(degree) for addressable PQ
- make mc64 "kernels" header declarations macros for easier consistency
- snake case
- improved formatting
- Mc64 is now final
- remove nonexistent test
- remove unused variables
- replace -1 by invalid_index
- use node instead of value in addressable PQ
- fix variable shadowing

Co-authored-by: Marcel Koch <marcel.koch@kit.edu>
Co-authored-by: Yuhsiang M. Tsai <yhmtsai@gmail.com>
    @upsj @MarcelKoch @yhmtsai
    3 people committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    de8e463 View commit details
    Browse the repository at this point in the history

  23. handle empty inputs

    @upsj
    upsj committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    37a88f1 View commit details
    Browse the repository at this point in the history

  24. disable MSVC debug build

    @upsj
    upsj committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    6de5034 View commit details
    Browse the repository at this point in the history

  25. add MSVC release shared

    @upsj
    upsj committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    87b7cad View commit details
    Browse the repository at this point in the history

  26. test mc64 float arrays only approximately

    @upsj
    upsj committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    15929b5 View commit details
    Browse the repository at this point in the history

  27. fix link, clarify variables in mc64_kernels test

    @upsj
    upsj committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    0a1e922 View commit details
    Browse the repository at this point in the history