Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix distributed vector merge #1030

Merged
merged 38 commits into from
Apr 21, 2022
Merged

Fix distributed vector merge #1030

merged 38 commits into from
Apr 21, 2022

Commits on Apr 21, 2022

  1. add kernels for intermediate norm computation 

    Co-authored-by: Tobias Ribizel <ribizel@kit.edu>
Co-authored-by: Pratik Nayak <pratik.nayak@kit.edu>
    @MarcelKoch @upsj @pratikvn
    3 people committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    a9759c1 View commit details
    Browse the repository at this point in the history

  2. add distributed vector class 

    Co-authored-by: Tobias Ribizel <ribizel@kit.edu>
Co-authored-by: Pratik Nayak <pratik.nayak@kit.edu>
    @MarcelKoch @upsj @pratikvn
    3 people committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    be01790 View commit details
    Browse the repository at this point in the history

  3. add tests for distributed vector

    @MarcelKoch
    MarcelKoch committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    33bd901 View commit details
    Browse the repository at this point in the history

  4. rework read distributed reference kernels

    @MarcelKoch
    MarcelKoch committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    4e6d5de View commit details
    Browse the repository at this point in the history

  5. fix formatting

    @MarcelKoch
    MarcelKoch committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    9786387 View commit details
    Browse the repository at this point in the history

  6. make name of constant accessor more reflective

    @MarcelKoch
    MarcelKoch committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    71a9eae View commit details
    Browse the repository at this point in the history

  7. update local vector typename

    @MarcelKoch
    MarcelKoch committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    fe94d0d View commit details
    Browse the repository at this point in the history

  8. minor refactoring

    @MarcelKoch
    MarcelKoch committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    c4615ed View commit details
    Browse the repository at this point in the history

  9. Format files 

    Co-authored-by: Marcel Koch <marcel.koch@kit.edu>
    @ginkgo-bot @MarcelKoch
    ginkgo-bot and MarcelKoch committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    1238d5c View commit details
    Browse the repository at this point in the history

  10. use GPU aware MPI if specified 

    the user has to set the cmake variable GINKGO_FORCE_GPU_AWARE_MPI to a true value, to enable this behavior. If not set, additional transfers to the host are used.

Co-authored-by: Pratik Nayak <pratik.nayak@kit.edu>
    @MarcelKoch @pratikvn
    MarcelKoch and pratikvn committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    07f1f67 View commit details
    Browse the repository at this point in the history

  11. review updates 

    - change build_local reference + omp implementation
- add build_local omp kernel test
- add vector constructor with explicit stride

Co-authored-by: Pratik Nayak <pratik.nayak@kit.edu>
Co-authored-by: Tobias Ribizel <ribizel@kit.edu>
    @MarcelKoch @pratikvn @upsj
    3 people committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    e87d9aa View commit details
    Browse the repository at this point in the history

  12. adds DenseCache to reuse a dense vector without repeated allocations 

    Co-authored-by: Tobias Ribizel <ribizel@kit.edu>
    @MarcelKoch @upsj
    MarcelKoch and upsj committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    278daf2 View commit details
    Browse the repository at this point in the history

  13. fixes switch to soa of device matrix data from rebase

    @MarcelKoch
    MarcelKoch committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    c6a92ae View commit details
    Browse the repository at this point in the history

  14. remove partition from read* and make partition mandatory in constructor

    @MarcelKoch
    MarcelKoch committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    6a38b08 View commit details
    Browse the repository at this point in the history

  15. remove partition member from vector 

    for now, no functionality (except reading/consistency checking) depends on the partition, so there is no point in storing it. Regarding the consistency check: we can ignore that for the moment, since we have to use a pointer comparison to check for equality, which is not sufficient for the general use case.
    @MarcelKoch
    MarcelKoch committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    6503e40 View commit details
    Browse the repository at this point in the history

  16. Format files 

    Co-authored-by: Marcel Koch <marcel.koch@kit.edu>
    @ginkgo-bot @MarcelKoch
    ginkgo-bot and MarcelKoch committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    f54f69b View commit details
    Browse the repository at this point in the history

  17. keep communicator on assignment

    @MarcelKoch
    MarcelKoch committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    0e260a7 View commit details
    Browse the repository at this point in the history

  18. review updates 

    - adds tests
- updates some documentation
- moves mutability into DenseCache
- reuses already allocated memory for read if available

Co-authored-by: Tobias Ribizel <ribizel@kit.edu>
Co-authored-by: Pratik Nayak <pratik.nayak@kit.edu>
    @MarcelKoch @upsj @pratikvn
    3 people committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    6ff2672 View commit details
    Browse the repository at this point in the history

  19. refactor cmake mpi test handling

    @MarcelKoch
    MarcelKoch committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    2291e5d View commit details
    Browse the repository at this point in the history

  20. add cmake function for common mpi test

    @MarcelKoch
    MarcelKoch committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    b925a03 View commit details
    Browse the repository at this point in the history

  21. adds missing typedef documentation

    @MarcelKoch
    MarcelKoch committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    3d7fa0f View commit details
    Browse the repository at this point in the history

  22. adds exec initializer with MPI for common test

    @MarcelKoch
    MarcelKoch committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    7f38ddf View commit details
    Browse the repository at this point in the history

  23. fix need for host buffer check

    @MarcelKoch
    MarcelKoch committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    d829584 View commit details
    Browse the repository at this point in the history

  24. add common mpi test for vector

    @MarcelKoch
    MarcelKoch committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    a01f74e View commit details
    Browse the repository at this point in the history

  25. adds constructor from local vector

    @MarcelKoch
    MarcelKoch committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    9df6a96 View commit details
    Browse the repository at this point in the history

  26. adds create_real_view to distributed vector

    @MarcelKoch
    MarcelKoch committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    d0da2ac View commit details
    Browse the repository at this point in the history

  27. move read_distributed impl to .cpp

    @MarcelKoch
    MarcelKoch committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    d57202b View commit details
    Browse the repository at this point in the history

  28. use unique ptr for local vector parameter

    @MarcelKoch
    MarcelKoch committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    7a88297 View commit details
    Browse the repository at this point in the history

  29. add constructor tests

    @MarcelKoch
    MarcelKoch committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    364da22 View commit details
    Browse the repository at this point in the history

  30. review updates 

    - formating
- test updates
- documentation

Co-authored-by: Tobias Ribizel <ribizel@kit.edu>
Co-authored-by: Pratik Nayak <pratik.nayak@kit.edu>
    @MarcelKoch @upsj @pratikvn
    3 people committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    3ac773e View commit details
    Browse the repository at this point in the history

  31. make dense::move_to adhere to move semantics 

    will be superseeded by #753
    @MarcelKoch
    MarcelKoch committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    ba75555 View commit details
    Browse the repository at this point in the history

  32. add test to check create_real_view behaviour

    @MarcelKoch
    MarcelKoch committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    c1f2eb1 View commit details
    Browse the repository at this point in the history

  33. review updates 

    - small rename
- documentation
- cmake
- tests

Co-authored-by: Yuhsiang Tsai <yhmtsai@gmail.com>
    @MarcelKoch @yhmtsai
    MarcelKoch and yhmtsai committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    2578a9c View commit details
    Browse the repository at this point in the history

  34. merge reference and common mpi tests 

    Co-authored-by: Yuhsiang Tsai <yhmtsai@gmail.com>
Co-authored-by: Tobias Ribizel <ribizel@kit.edu>
    @MarcelKoch @yhmtsai @upsj
    3 people committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    1fecf62 View commit details
    Browse the repository at this point in the history

  35. review updates 

    - formating
- fix DenseCache::init_from
- fix tests if comm.size != 3

Co-authored-by: Yuhsiang Tsai <yhmtsai@gmail.com>
    @MarcelKoch @yhmtsai
    MarcelKoch and yhmtsai committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    40234e7 View commit details
    Browse the repository at this point in the history

  36. only allow const access to local vector 

    this adds in turn mutable access through get_local_values and at_local

Co-authored-by: Tobias Ribizel <ribizel@kit.edu>
    @MarcelKoch @upsj
    MarcelKoch and upsj committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    c5514f5 View commit details
    Browse the repository at this point in the history

  37. fixes sonarcloud issues where it makes sense

    @MarcelKoch
    MarcelKoch committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    ca07957 View commit details
    Browse the repository at this point in the history

  38. Format files 

    Co-authored-by: Marcel Koch <marcel.koch@kit.edu>
    @ginkgo-bot @MarcelKoch
    ginkgo-bot and MarcelKoch committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    5edadcf View commit details
    Browse the repository at this point in the history