-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve reordering interface #940
Comments
This is somewhat relevant here: the operation S1-1 A S2-1 S2 x = S1-1 b is needed for "batched scaled" batch solvers. Usually, the left matrix would be applied to both the matrix and the RHS vector, and could be done together. Therefore, for now I introduced a free function |
This was only partially closed by the aforementioned PR, the issues with the |
Fixed by #1415 |
As observed in #939, our reordering interface is easy to accidentally misuse.
Part of the issue is that Permutation violates the LinOp assumptions in some situations. A permutation matrix is square and, applied from the left (as
LinOp::apply
is intended), it permutes the rows of the input matrix. At the same time, Permutation allows column partitions and symmetric partitions with the sameapply
interface, even though they would be more correctly represented by aright_apply
andconjugate_apply
or however we want to call a Similarity Transformation, because with the plain LinOp interface, column permutations of non-square matrices are not possible at all, and symmetric permutations are not possible dimension-wise.Related issue: #346
The text was updated successfully, but these errors were encountered: