Fix URL path value still unescaped when UnescapePathValues set false #4036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimChenWYU
commented
Aug 20, 2024
| @@ -242,7 +242,7 @@ func LoggerWithConfig(conf LoggerConfig) HandlerFunc { | |||
| return func(c *Context) { | |||
| // Start timer | |||
| start := time.Now() | |||
| path := c.Request.URL.Path | |||
| path := c.Request.URL.EscapedPath() | |||
There was a problem hiding this comment.
using Path it seem something wrong in this case.
ALX99
reviewed
Aug 21, 2024
gin.go
Outdated
| @@ -645,7 +645,7 @@ func (engine *Engine) HandleContext(c *Context) { | |||
|
|
|||
| func (engine *Engine) handleHTTPRequest(c *Context) { | |||
| httpMethod := c.Request.Method | |||
| rPath := c.Request.URL.Path | |||
| rPath := c.Request.URL.EscapedPath() | |||
There was a problem hiding this comment.
This should not be changed right?
Now we are always routing based on the EscapedPath which changes the default behaviour
There was a problem hiding this comment.
This should not be changed right? Now we are always routing based on the
EscapedPathwhich changes the default behaviour
You are right.
gin.go
Outdated
Comment on lines
648
to
651
| rPath := c.Request.URL.EscapedPath() | ||
| unescape := false | ||
| if engine.UseRawPath && len(c.Request.URL.RawPath) > 0 { | ||
| rPath = c.Request.URL.RawPath |
There was a problem hiding this comment.
Suggested change
| rPath := c.Request.URL.EscapedPath() | |
| unescape := false | |
| if engine.UseRawPath && len(c.Request.URL.RawPath) > 0 { | |
| rPath = c.Request.URL.RawPath | |
| rPath := c.Request.URL.Path | |
| unescape := false | |
| if engine.UseRawPath { | |
| rPath = c.Request.URL.EscapedPath() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4033