Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added option to disable default field and enable latency #81

Closed
wants to merge 3 commits into from
Closed

feat: Added option to disable default field and enable latency #81

wants to merge 3 commits into from

Conversation

aleksasiriski
Copy link

@aleksasiriski aleksasiriski commented Feb 4, 2024

Useful if someone doesn't want to log some of the fields provided with this package.
Example: IP / UserAgent could be sensitive info that someone using this package DOES NOT want to have logged.

@aleksasiriski aleksasiriski changed the title feat: added option to disable default field and enable latency feat: Added option to disable default field and enable latency Feb 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 42.30769% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 84.09%. Comparing base (d96c742) to head (623ef20).
Report is 8 commits behind head on master.

Files Patch % Lines
options.go 0.00% 8 Missing ⚠️
logger.go 61.11% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #81       +/-   ##
===========================================
- Coverage   94.24%   84.09%   -10.16%     
===========================================
  Files           2        2               
  Lines         139      132        -7     
===========================================
- Hits          131      111       -20     
- Misses          5       18       +13     
  Partials        3        3               
Flag Coverage Δ
go- 84.09% <42.30%> (-10.16%) ⬇️
go-1.18 84.09% <42.30%> (-10.16%) ⬇️
go-1.19 84.09% <42.30%> (-10.16%) ⬇️
go-1.20 84.09% <42.30%> (-10.16%) ⬇️
go-1.21 84.09% <42.30%> (-10.16%) ⬇️
go-1.22 84.09% <42.30%> (-10.16%) ⬇️
macos-latest 84.09% <42.30%> (-10.16%) ⬇️
ubuntu-latest 84.09% <42.30%> (-10.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aleksasiriski
Copy link
Author

@appleboy Any reason this ultra small PR in this extremely small package isn't merged 1 month after? Why would you still force all logs to store sensitive info about user making the requests, some people don't want that.

@appleboy
Copy link
Member

appleboy commented Mar 2, 2024

@aleksasiriski

Apologies, as of now, there are only two maintainers for Gin, me and @thinkerou. We plan to recruit more maintainers in the future to ensure that everyone's inquiries receive timely feedback.

Regarding this PR, I will take it soon, and any updates will be communicated through comments.

@hearchco hearchco closed this by deleting the head repository Mar 27, 2024
@aleksasiriski
Copy link
Author

You can take the code from this PR and apply it to your project, I've deleted the repo since Hearchco moved from gin to go-chi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants