-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codespell support (config, workflow to detect/not fix) and make it fix few typos #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
=== Do not change lines below === { "chain": [], "cmd": "codespell -w", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^
interesting! enabling the CI for this PR. |
Merged
@yarikoptic thanks for this. Merged. I had to fix a couple of CI errors not related to your commits. |
will be making a release this weekend |
truecharts-admin
referenced
this pull request
in truecharts/charts
Jul 24, 2024
… v3.2.5@bd89d19 by renovate (#24088) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/gilesknap/gphotos-sync](https://github.com/gilesknap/gphotos-sync) | patch | `3.2.4` -> `3.2.5` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>gilesknap/gphotos-sync (ghcr.io/gilesknap/gphotos-sync)</summary> ### [`v3.2.5`](https://github.com/gilesknap/gphotos-sync/releases/tag/3.2.5) [Compare Source](https://github.com/gilesknap/gphotos-sync/compare/3.2.4...3.2.5) #### What's Changed - Codespell by [@​gilesknap](https://github.com/gilesknap) in [https://github.com/gilesknap/gphotos-sync/pull/498](https://github.com/gilesknap/gphotos-sync/pull/498) - Add codespell support (config, workflow to detect/not fix) and make it fix few typos by [@​yarikoptic](https://github.com/yarikoptic) in [https://github.com/gilesknap/gphotos-sync/pull/496](https://github.com/gilesknap/gphotos-sync/pull/496) - include Timeout errors in bad_ids and close future on raise - fixes [#​480](https://github.com/gilesknap/gphotos-sync/issues/480) and [#​488](https://github.com/gilesknap/gphotos-sync/issues/488) by [@​gilesknap](https://github.com/gilesknap) in [https://github.com/gilesknap/gphotos-sync/pull/499](https://github.com/gilesknap/gphotos-sync/pull/499) - Readme fix by [@​gilesknap](https://github.com/gilesknap) in [https://github.com/gilesknap/gphotos-sync/pull/500](https://github.com/gilesknap/gphotos-sync/pull/500) #### New Contributors - [@​yarikoptic](https://github.com/yarikoptic) made their first contribution in [https://github.com/gilesknap/gphotos-sync/pull/496](https://github.com/gilesknap/gphotos-sync/pull/496) **Full Changelog**: gilesknap/gphotos-sync@3.2.4...3.2.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNiIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC42IiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbImF1dG9tZXJnZSIsInVwZGF0ZS9kb2NrZXIvZ2VuZXJhbC9ub24tbWFqb3IiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More about codespell: https://github.com/codespell-project/codespell .
I personally introduced it to dozens if not hundreds of projects already and so far only positive feedback.
CI workflow has 'permissions' set only to 'read' so also should be safe.