Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customization of the template content closes #3 #4

Merged
merged 26 commits into from
Jul 21, 2023

Conversation

augustocristian
Copy link
Contributor

@augustocristian augustocristian commented Jul 20, 2023

  • Removed modules not used
  • Changed module-project names to retorch and retorch-annotations
  • Namespace renamed to giis.retorch.annotations
  • Test case modifed to pass (uses one of the modules removed)
  • Some little spell mistakes corrected.
  • Added .settings to the module retorch-annotations (ignored originally by the gitignore)
  • SonarQube configurations performed
  • Customization of the master and retorch-annotations pom.xml files
  • First version of the README.md with basic information about the annotations, contributing, citation,contact etc.

.idea/.gitignore Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
retorch-annotations/pom.xml Outdated Show resolved Hide resolved
sonar-project.properties Outdated Show resolved Hide resolved
@javiertuya
Copy link
Contributor

@augustocristian Just a tip: you don't need to always push every internal commit that you do because each push starts all workflows and sonar (if configured)

@augustocristian
Copy link
Contributor Author

Dear @javiertuya
Now everything seems to be working correctly. I made changes to the URL artifacts in the pom.xml. Initially, I thought this information/parametrization was included in the Actions file. However, after reviewing it, I realized it needed to be modified in the pom.xml instead.

Copy link
Contributor

@javiertuya javiertuya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI You don't need use mentins to request review. you can use the button at the top right of the screen to request review

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@augustocristian
Copy link
Contributor Author

Personalized the README, following the sections of td-rules plus some extra (contact and acks) as well as the the first draft of the annotations

@javiertuya
Copy link
Contributor

@augustocristian Remember that the comment that originated this was *Customize this description: a simple statement to say what is retorch, the annotations. Include a note to explain that annotations are the only available now, but in a near future, other retorch componentes will be available.".

You can keep the details, but please, include the note referred to in the second part

We only use html to provide text aligment (its not natively supported by markdown)
Added also links to the article, the official springer citation and authors version
@augustocristian
Copy link
Contributor Author

I apologize for the misunderstanding. I understood that this minor personalization was intended only in the pom.xml file (with the note that not all components are available at the moment), so when this morning I realized the change resquest in the readme, I thought it was to include all (at least a preliminary version)

@javiertuya
Copy link
Contributor

@augustocristian Is this for review? there are 2 unresolved conversations. No PR can be merged if any conversation is unresolved.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@augustocristian
Copy link
Contributor Author

augustocristian commented Jul 21, 2023

I have accepted all the requested changes and uploaded them to the repository. Why is one change still appearing as needing acceptance? @javiertuya
I only found this:
image

@javiertuya javiertuya merged commit c72ce7b into main Jul 21, 2023
7 checks passed
@javiertuya javiertuya deleted the ft_customize_template_content branch July 21, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants