-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customization of the template content closes #3 #4
Conversation
augustocristian
commented
Jul 20, 2023
•
edited
Loading
edited
- Removed modules not used
- Changed module-project names to retorch and retorch-annotations
- Namespace renamed to giis.retorch.annotations
- Test case modifed to pass (uses one of the modules removed)
- Some little spell mistakes corrected.
- Added .settings to the module retorch-annotations (ignored originally by the gitignore)
- SonarQube configurations performed
- Customization of the master and retorch-annotations pom.xml files
- First version of the README.md with basic information about the annotations, contributing, citation,contact etc.
samples-giis-template-m1/.settings/org.eclipse.core.resources.prefs
Outdated
Show resolved
Hide resolved
@augustocristian Just a tip: you don't need to always push every internal commit that you do because each push starts all workflows and sonar (if configured) |
Dear @javiertuya |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI You don't need use mentins to request review. you can use the button at the top right of the screen to request review
Personalized the README, following the sections of td-rules plus some extra (contact and acks) as well as the the first draft of the annotations |
@augustocristian Remember that the comment that originated this was *Customize this description: a simple statement to say what is retorch, the annotations. Include a note to explain that annotations are the only available now, but in a near future, other retorch componentes will be available.". You can keep the details, but please, include the note referred to in the second part |
We only use html to provide text aligment (its not natively supported by markdown)
Added also links to the article, the official springer citation and authors version
I apologize for the misunderstanding. I understood that this minor personalization was intended only in the pom.xml file (with the note that not all components are available at the moment), so when this morning I realized the change resquest in the readme, I thought it was to include all (at least a preliminary version) |
@augustocristian Is this for review? there are 2 unresolved conversations. No PR can be merged if any conversation is unresolved. |
I have accepted all the requested changes and uploaded them to the repository. Why is one change still appearing as needing acceptance? @javiertuya |