This repository has been archived by the owner on Apr 12, 2023. It is now read-only.
Updates for 1.7 cadvisor changes and rbac requirements #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using /var would remove grafana-specific data whereas using /var/lib/grafana as per the official Dockerfile reference states, it works as expected after pod deletion(s).
… its own namespace
Fix issue with grafana-specific data not persisting
|
This is breaking for K8s 1.7.2 and below, correct? If so, then please add a note about this being the case in the readme. I will do some testing from my side shortly. |
|
I'll see if I can roll out some older 1.7.x clusters to test. |
|
Tested on 1.7.6 cluster. Works fine. Thanks @zatricky ! |
r4j4h
reviewed
Oct 3, 2017
r4j4h
reviewed
Oct 3, 2017
sctsang
referenced
this pull request
in sctsang/kubernetes-prometheus
Feb 15, 2018
timn
referenced
this pull request
in timn/rcll-sim-cluster
Jun 14, 2018
Pull latest upstream and PR #73 for compatibility with K8s 1.9 (giantswarm/kube-prometheus-stack-app#73). Then go on and upgrade to Prometheus 2.1, related tools, Grafana to 4.6.3. Make the necessary configuration changes especially to alerts for Prometheus 2. Move import job init container into spec.
This was referenced Nov 7, 2018
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
See also: