Fixed issue 863. Uses the MEMORY_BASIC_INFORMATION64 struct and retur… #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns a 64bit baseAddress when compiled for 64 bit windows
| MEMORY_BASIC_INFORMATION64 basicInfo; | ||
| #else | ||
| MEMORY_BASIC_INFORMATION basicInfo; | ||
| #endif |
There was a problem hiding this comment.
Please indent the ifdefs properly (no spaces) and also the variable names should be indented like the others below
|
I added some comments inline. Other than that, can you please also update HISTORY and CREDITS files? Thanks a lot. |
|
I made your suggested changes. Let me know if I missed anything. Thanks! |
| "(kssI)", | ||
| (unsigned long)baseAddress, | ||
| #endif | ||
| (unsigned long long)baseAddress, |
There was a problem hiding this comment.
this looks wrong. Shouldn't this line be inside the ifdef statement?
You should do:
+#ifdef _WIN64
+ py_tuple = Py_BuildValue(
+ "(KssI)",
+ (unsigned long long)baseAddress,
+#else
+ py_tuple = Py_BuildValue(
+ "(kssI)",
+ (unsigned long)baseAddress,
+#endif
...
|
You're right on both. Sorry, I'm pretty new to pull requests here. I'll try to just delete this request and make a new one off of master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ns a 64bit baseAddress when compiled for 64 bit windows