Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes swap_memory not returning bytes on FreeBSD #1260

Merged
merged 1 commit into from
Mar 29, 2018
Merged

Fixes swap_memory not returning bytes on FreeBSD #1260

merged 1 commit into from
Mar 29, 2018

Conversation

href
Copy link
Contributor

@href href commented Mar 29, 2018

This fixes #1255

@giampaolo
Copy link
Owner

Thanks. Did you verify it matches swapinfo? It would be nice to add a unit test for it checking swapinfo output in test_bsd.py.

@href
Copy link
Contributor Author

href commented Mar 29, 2018

I did, and there is a test in test_bsd.py ;)

@giampaolo
Copy link
Owner

Great stuff! Merging.

@giampaolo giampaolo merged commit a4c07e9 into giampaolo:master Mar 29, 2018
@href
Copy link
Contributor Author

href commented Mar 29, 2018

Cheers! As an aside: I love how straight forward it was to get the tests for this project running 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug freebsd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

swap_memory is not in bytes on FreeBSD
2 participants
@href @giampaolo