Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert-hf : print output file name when completed #8181

Merged

Commits on Jun 28, 2024

  1. convert-hf : print output file name when completed

    This commit adds the output file name to the log message when the
    conversion is completed.
    
    The motivation for this change is that when `--outfile` option is not
    specified it migth not be obvious where the output file is written.
    
    With this change the output of running the script will be something like
    the following:
    ```console
    INFO:hf-to-gguf:Model successfully exported to models/gemma-2-9b-it.gguf.
    ```
    
    Signed-off-by: Daniel Bevenius <daniel.bevenius@gmail.com>
    danbev committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    2423833 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2024

  1. squash! convert-hf : print output file name when completed

    Updates the output of to support printing the directory if the output is
    split into multiple files. Also the output file name is now retrieved
    from the model_instance object.
    
    Signed-off-by: Daniel Bevenius <daniel.bevenius@gmail.com>
    danbev committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    6879fb5 View commit details
    Browse the repository at this point in the history
  2. squash! convert-hf : print output file name when completed

    Use parent attribute of Path object and string interpolation.
    
    Signed-off-by: Daniel Bevenius <daniel.bevenius@gmail.com>
    danbev committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    cd8c573 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2024

  1. squash! convert-hf : print output file name when completed

    Use os.sep instead of hardcoding the path separator.
    
    Signed-off-by: Daniel Bevenius <daniel.bevenius@gmail.com>
    danbev committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    49d31f7 View commit details
    Browse the repository at this point in the history