Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable uniformity analysis for the fragment stage #2515

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Disable uniformity analysis for the fragment stage #2515

merged 2 commits into from
Sep 28, 2023

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Sep 26, 2023 •
edited
Loading

Disables uniformity requirements for the following:

  • derivative builtin functions
  • textureSample
  • textureSampleBias
  • textureSampleCompare

These are the same builtins derivative_uniformity diagnostic targets.

This is a temporary change until we get to gfx-rs/wgpu#4369.

jimblandy
jimblandy approved these changes Sep 28, 2023
View reviewed changes
src/valid/analyzer.rs Show resolved Hide resolved
@teoxoy teoxoy merged commit e6a47ba into gfx-rs:master Sep 28, 2023
5 checks passed
@teoxoy teoxoy deleted the disable-uniformity-req-on-fragment-stage branch October 3, 2023 15:49
@dneto0 dneto0 mentioned this pull request Jan 21, 2022
Closed
@chenrui333 chenrui333 mentioned this pull request Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimblandy jimblandy jimblandy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teoxoy @jimblandy