[wgsl-out] Simplify map_binding_to_attribute to always return an interpolate attribute #2318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! CI is failing since you need to also push the updated test snapshots. |
expenses
changed the title
expenses
force-pushed
the
wgsl-out-interpolate-flat
branch
from
5cdd1e9
to
dcd6010
Compare
Elabajaba
pushed a commit
to Elabajaba/naga
that referenced
this pull request
Jul 2, 2023
…rpolate attribute (gfx-rs#2318) (cherry picked from commit da3f433)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effectively reverts #1103. Fixes #1491. @teoxoy @cwfitzgerald @kvark.