Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hlsl-out] Fix return type for firstbitlow/high #2315

Merged
merged 2 commits into from
Apr 25, 2023
Merged

[hlsl-out] Fix return type for firstbitlow/high #2315

merged 2 commits into from
Apr 25, 2023

Conversation

evahop
Copy link
Contributor

@evahop evahop commented Apr 24, 2023

Fixes #1939 where firtbitlow and firstbithigh always return a uint.

teoxoy
teoxoy approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@teoxoy teoxoy merged commit 9befaed into gfx-rs:master Apr 25, 2023
@evahop evahop deleted the hlsl-bit-casts branch September 28, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoxoy teoxoy teoxoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[hlsl-out] Incorrect behaviour with firstTrailingBit
2 participants
@evahop @teoxoy