[wgsl] Use alias instead of type for type aliases
#2299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #2299 +/- ##
=======================================
Coverage 82.19% 82.19%
=======================================
Files 82 82
Lines 44262 44272 +10
=======================================
+ Hits 36379 36389 +10
Misses 7883 7883
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ErichDonGubler
approved these changes
Apr 3, 2023
jimblandy
previously requested changes
Apr 3, 2023
teoxoy
changed the title
alias instead of type for type aliases
HeroicKatora
added a commit
to HeroicKatora/rend3
that referenced
this pull request
Jul 6, 2023
Following the spec, via: <gfx-rs/naga#2299>
cwfitzgerald
pushed a commit
to BVE-Reborn/rend3
that referenced
this pull request
Jul 16, 2023
Following the spec, via: <gfx-rs/naga#2299>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings us in line with the spec: https://gpuweb.github.io/gpuweb/wgsl/#type-aliases
Currently Canary fails with
typekeyword.