fix(hlsl): emit constructor functions for arrays

[ErichDonGubler]

Fixes #2184.

Before: https://shader-playground.timjones.io/834690cc5ef4adbce8eebfbcaf721f76

After: https://shader-playground.timjones.io/0c093b24eb01d3974e7e5d130ed5b021

[ErichDonGubler]

Looks like CI is only failing on #2279. 😮‍💨👍🏻

[teoxoy]

Looks like CI is only failing on #2279. 😮‍💨👍🏻

A rebase should get it working.

[teoxoy]

LGTM, but let's add/extend one of the test snapshots with the code that was previously not getting translated correctly (from #2184)

[ErichDonGubler]

@teoxoy: Added a new test! I broke out a commit for adding a deliberately failing test case in HLSL, and then fixing it in the subsequent commit. Not sure if that's how you'd like to commit it, but I'm open to changing it if you want. 😊

[teoxoy]

I broke out a commit for adding a deliberately failing test case in HLSL, and then fixing it in the subsequent commit. Not sure if that's how you'd like to commit it, but I'm open to changing it if you want.

That's great for PRs - makes it a lot clearer when looking at the commit that fixes the issue the things that changed in the snapshots.

But I don't think we should merge the commits separately though since if you'd bisect on the first commit, the tests will fail.

[teoxoy]

Good stuff!