Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip gl_PerVertex unused builtins in the SPIR-V frontend #2272

Merged
merged 2 commits into from
Mar 15, 2023

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Mar 9, 2023

also closes #2182

@teoxoy teoxoy marked this pull request as ready for review March 9, 2023 23:21
@teoxoy teoxoy force-pushed the spv-in-skip-unused-builtins branch from c57c08a to 68fb71a Compare March 9, 2023 23:25
@teoxoy teoxoy force-pushed the spv-in-skip-unused-builtins branch from 68fb71a to 8a0ea7f Compare March 10, 2023 16:54
Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some very minor suggestions

src/back/msl/writer.rs Show resolved Hide resolved
src/front/glsl/variables.rs Show resolved Hide resolved
src/front/spv/function.rs Outdated Show resolved Hide resolved
Co-authored-by: Jim Blandy <jimb@red-bean.com>
@teoxoy teoxoy merged commit 63e91fa into gfx-rs:master Mar 15, 2023
@teoxoy teoxoy deleted the spv-in-skip-unused-builtins branch March 15, 2023 17:46
kvark pushed a commit to kvark/naga that referenced this pull request Mar 18, 2023
Co-authored-by: Jim Blandy <jimb@red-bean.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hlsl-out] Remove BuiltIn::PointSize/PSIZE
2 participants