Differentiate between i32 and u32 in switch #2269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #2269 +/- ##
==========================================
- Coverage 82.05% 82.04% -0.02%
==========================================
Files 80 80
Lines 43241 43250 +9
==========================================
+ Hits 35481 35483 +2
- Misses 7760 7767 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
teoxoy
requested changes
Mar 10, 2023
There was a problem hiding this comment.
This looks good; thanks for the PR!
Added a duplicate
SwitchValueenum to validation since I wasn't sure if adding additional derives tolibwas appropriate or not. This adds a tiny bit of redundancy that I can remove if needed.
I think it should be fine to just derive Copy, Eq, Hash, PartialEq on the original enum.
teoxoy
approved these changes
Mar 10, 2023
kvark
pushed a commit
to kvark/naga
that referenced
this pull request
Mar 18, 2023
* Differentiate between i32 and u32 in switch * Use similar wording to other error messages * Remove duplicate enum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1960.
Updated all instances of
SwitchValue::Integerto include uints.Renamed
select_casestoswitch_valuessince it did not appear to be used for anything other than switch values.Added a check to validate all cases had similar types. That's just how I interpreted this bit from the spec.
Added a duplicate
SwitchValueenum to validation since I wasn't sure if adding additional derives tolibwas appropriate or not. This adds a tiny bit of redundancy that I can remove if needed.