Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split image bounds check policy #2265

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Mar 3, 2023

Split image bounds check policy since we shouldn't need bounds checks for writes.
See gpuweb/gpuweb#3893 (comment).

@jimblandy
Copy link
Member

jimblandy commented Jun 22, 2023

Since all the backends ignore writes anyway, the only thing one can do with an image write policy is ask for Restrict, which seems like something nobody actually prefers.

Wouldn't it make more sense to just rename BoundsCheckPolicy::image to image_load, and remove bounds checking on ImageStore altogether?

@teoxoy
Copy link
Member Author

teoxoy commented Jun 23, 2023

I wanted to first see the guarantee landed in the spec. Put up: gpuweb/gpuweb#4194

Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We can just drop image_store if that comes to pass.

src/proc/index.rs Outdated Show resolved Hide resolved
src/proc/index.rs Outdated Show resolved Hide resolved
Co-authored-by: Jim Blandy <jimb@red-bean.com>
@teoxoy teoxoy enabled auto-merge (squash) June 29, 2023 14:56
@teoxoy teoxoy merged commit a550b0b into gfx-rs:master Jun 29, 2023
5 checks passed
@teoxoy teoxoy deleted the split-image-bounds-check-policy branch June 30, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants