Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wgsl] Partially Update Built-in Functions #2218

Merged
merged 3 commits into from
Jan 23, 2023
Merged

Conversation

evahop
Copy link
Contributor

@evahop evahop commented Jan 23, 2023

The following were low-hanging fruit from gfx-rs/wgpu#4402.
I intended to do the remainder, but it may take me some time to reason about the different backends.

Adds

  • acosh, asinh, atanh
  • refract

Removes

  • isFinite, isNormal

Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for the PR!

@teoxoy teoxoy merged commit a638da9 into gfx-rs:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants