Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the uniformity analysis trust the handle validation pass. #2200

Merged
merged 1 commit into from
Jan 15, 2023

Conversation

jimblandy
Copy link
Member

Undo some changes from #1668, now that #2090 has been merged.

cc @ErichDonGubler

@jimblandy jimblandy requested a review from teoxoy January 10, 2023 00:36
Copy link
Member

@ErichDonGubler ErichDonGubler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far, after skimming through everything. Wanted to double-check what cases still remain on my desktop in my tomorrow morning.

Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, besides the comment

src/valid/analyzer.rs Show resolved Hide resolved
@jimblandy jimblandy enabled auto-merge (rebase) January 11, 2023 01:07
@jimblandy
Copy link
Member Author

Rebase after a bad merge.

@jimblandy jimblandy merged commit cdcfad2 into gfx-rs:master Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants