Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[glsl-out] emit reflection info for non-struct uniforms #2189

Merged
merged 1 commit into from
Jan 4, 2023
Merged

[glsl-out] emit reflection info for non-struct uniforms #2189

merged 1 commit into from
Jan 4, 2023

Conversation

Rainb0wCodes
Copy link
Contributor

@Rainb0wCodes Rainb0wCodes commented Dec 30, 2022 •
edited
Loading

Every global variable with AddressSpace::Uniform | AddressSpace::Storage will be written using write_interface_block, so this just exposes the reflection information that was previously private.

teoxoy
teoxoy approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

@teoxoy teoxoy merged commit e98bd92 into gfx-rs:master Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoxoy teoxoy teoxoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rainb0wCodes @teoxoy