Allow u32 coordinates for textureStore/textureLoad

[PENGUINLIONG]

As illustrated in https://www.w3.org/TR/WGSL/#texturestore:

F is a texel format
C is i32, or u32
...

So I guess vec<u32> should be a valid textureStore coordinate.

I saw that in back::glsl::write_texture_coord the coord is explicitly cast to ivec so I think that's good. Please remind me if anything should be changed accordingly in the codegens.

[teoxoy]

I looked over the backends and this shouldn't cause any issues.
Could you add some lines to the tests/in/image.wgsl file to test for those overloads?

Thanks!

[teoxoy]

This PR would in theory allow textureLoad to also accept u32 coordinates. Could you also add a test for that?
Also, make sure you push the changed test snapshots (that's why CI is failing).

[teoxoy]

Looks like we need to check for component_kind == crate::ScalarKind::Uint and convert array_index_i32_id to a uint (similar to how we do for the else branch below).

naga/src/back/spv/image.rs

Lines 317 to 336 in 8e1b052

	let array_index_i32_id = self.cached[array_index];
	let reconciled_array_index_id = if component_kind == crate::ScalarKind::Sint {
	array_index_i32_id
	} else {
	let component_type_id = self.get_type_id(LookupType::Local(LocalType::Value {
	vector_size: None,
	kind: component_kind,
	width: 4,
	pointer_space: None,
	}));
	let reconciled_id = self.gen_id();
	block.body.push(Instruction::unary(
	spirv::Op::ConvertUToF,
	component_type_id,
	reconciled_id,
	array_index_i32_id,
	));
	reconciled_id
	};

[PENGUINLIONG]

ah thanks for the hint ;)

[PENGUINLIONG]

wow thats funny. i thought the glsl back is not affected.

[PENGUINLIONG]

Oof. Can I rerun the DXC test?

[teoxoy]

Looks good! Thanks!