Implement Binding Arrays #1845
Merged
Implement Binding Arrays #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
force-pushed
the
resource-binding-arrays-rebased
branch
from
1b95694
to
d22b70a
Compare
kvark
reviewed
Apr 17, 2022
| fn to_global_or_argument(&self) -> Result<GlobalOrArgument, ExpressionError> { | ||
| fn to_global_or_argument( | ||
| &self, | ||
| expression_arena: &Arena<crate::Expression>, |
There was a problem hiding this comment.
this becomes bad with this argument. If the function input is not one expression but multiple ones, it shouldn't be a method on the Expression any more. Let's turn it to a freestanding function (accepting an arena and a handle)? Or put it on the arena?
kvark
approved these changes
Apr 17, 2022
|
Should we also implement this for the SPIR-V frontend? (related to gfx-rs/wgpu#4463) |
|
Ideally both spirv and glsl, but those can be future prs |
cwfitzgerald
force-pushed
the
resource-binding-arrays-rebased
branch
from
d22b70a
to
825ca93
Compare
|
I'm going to merge this, and if you want a different representation of that function, I'll do a follow up PR |
jimblandy
added a commit
to jimblandy/naga
that referenced
this pull request
Sep 26, 2023
The duplicate entry was introduced accidentally in gfx-rs#1845.
jimblandy
added a commit
to jimblandy/naga
that referenced
this pull request
Sep 28, 2023
The duplicate entry was introduced accidentally in gfx-rs#1845.
teoxoy
pushed a commit
that referenced
this pull request
Sep 28, 2023
The duplicate entry was introduced accidentally in #1845.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #751
Sorry that this PR is larger than I'd like, I couldn't really land any part of it without other parts, so in an attempt to make things easier to review, I have segmented the PR into sections based on the section of code. While the commits are not standalone and this PR needs to be squashed, you can review this pr commit by commit.
This PR implements Binding Arrays and their indexing in the IR, Validator, wgsl-in, and {msl,hlsl,spv}-out.