Document proc::layouter.
#1693
Merged
Document proc::layouter.
#1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename `TypeLayoutError` to `LayoutErrorInner`, for consistency. It makes no sense to have 'Type' in the name of one of the error types but not the other. The 'Inner' convention is used by the module types. Cite the layout rules in the WGSL spec, not a GitHub issue.
jimblandy
force-pushed
the
doc-layouter
branch
from
3590ff7
to
b87b29c
Compare
kvark
approved these changes
Jan 24, 2022
| @@ -83,6 +101,19 @@ impl Layouter { | |||
| (start..start + span, alignment) | |||
| } | |||
|
|
|||
| /// Extend this `Layouter` with layouts for any new entries in `types`. | |||
There was a problem hiding this comment.
oh sweet, this function needed some text on it for sure!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
TypeLayoutErrortoLayoutErrorInner, for consistency. It makes no sense to have 'Type' in the name of one of the error types but not the other. The 'Inner' convention is used by the module types.Cite the layout rules in the WGSL spec, not a GitHub issue.
(I just wrote this while reviewing another PR.)