Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JWT Authentication; Refactoring #2

Merged
merged 10 commits into from
Jun 26, 2023
Merged

JWT Authentication; Refactoring #2

merged 10 commits into from
Jun 26, 2023

Conversation

danielchalef
Copy link
Member

@danielchalef danielchalef commented Jun 25, 2023 •
edited
Loading

  • authentication, remove axios instance from constructor, use global axios mock for testing
  • refactor error handling for DRY; add 401 auth error
  • fix package.json license
  • remove duplicate jest config

@danielchalef danielchalef marked this pull request as ready for review June 25, 2023 04:43
rsharath
rsharath reviewed Jun 26, 2023
View reviewed changes
Copy link
Contributor

@rsharath rsharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to take axios instance in the constructor for running unit/integ tests.

rsharath
rsharath approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@rsharath rsharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielchalef
Copy link
Member Author

We need to take axios instance in the constructor for running unit/integ tests.

An Axios instance is no longer required for testing as we mock the default / global Axios instance.

@danielchalef danielchalef merged commit 39ac98d into main Jun 26, 2023
3 checks passed
@danielchalef danielchalef deleted the jwt-auth branch June 26, 2023 15:59
@josiahbryan josiahbryan mentioned this pull request Jul 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsharath rsharath rsharath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielchalef @rsharath