Fix temporal invalidation unit tests #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from-context # Conflicts: # core/graphiti.py # core/utils/maintenance/node_operations.py
…from-context # Conflicts: # core/graphiti.py # core/prompts/dedupe_edges.py # core/prompts/invalidate_edges.py # core/utils/bulk_utils.py # core/utils/maintenance/edge_operations.py # core/utils/maintenance/node_operations.py # core/utils/maintenance/temporal_operations.py # core/utils/search/search_utils.py # runner.py
…ti into extract-dates-from-context
paul-paliychuk
had a problem deploying
to
development
GitHub Actions
Failure
paul-paliychuk
temporarily deployed
to
development
GitHub Actions
Inactive
paul-paliychuk
had a problem deploying
to
development
GitHub Actions
Failure
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 82a5731 in 7 seconds
More details
- Looked at
138lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. tests/utils/maintenance/test_temporal_operations.py:116
- Draft comment:
Consider using thecreate_test_datahelper function to set up nodes and edges for consistency and to reduce code duplication. - Reason this comment was not posted:
Confidence changes required:50%
The test functions are not using the helper functioncreate_test_dataconsistently. This can lead to code duplication and inconsistency in test data setup.
Workflow ID: wflow_ynBDn6Uf86vzWwcW
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
paul-paliychuk
had a problem deploying
to
development
GitHub Actions
Failure
paul-paliychuk
had a problem deploying
to
development
GitHub Actions
Failure
paul-paliychuk
temporarily deployed
to
development
GitHub Actions
Inactive
paul-paliychuk
temporarily deployed
to
development
GitHub Actions
Inactive
paul-paliychuk
temporarily deployed
to
development
GitHub Actions
Inactive
paul-paliychuk
had a problem deploying
to
development
GitHub Actions
Failure
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 868215c in 27 seconds
More details
- Looked at
92lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_T6db4QMkfvrPRo26
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
❌ Changes requested. Incremental review on dd04725 in 14 seconds
More details
- Looked at
15lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_RZfITvHe4oyvZpyO
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Enhanced unit tests to handle
EpisodicNodeinprepare_invalidation_context, ensuring correct episode processing.Key points:
tests/utils/maintenance/test_temporal_operations.py.EpisodicNodehandling inprepare_invalidation_context.test_prepare_invalidation_contextto includecurrent_episodeandprevious_episodes.current_episodeandprevious_episodes.prepare_invalidation_context.Generated with ❤️ by ellipsis.dev