Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add delete group endpoint #132

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

paul-paliychuk
Copy link
Collaborator

@paul-paliychuk paul-paliychuk commented Sep 20, 2024

Important

Add delete_group endpoint and method, handle errors, and update version.

  • Add delete_group endpoint in ingest.py to delete a group by group_id.
  • Implement delete_group method in ZepGraphiti class in zep_graphiti.py to delete all edges, nodes, and episodes associated with a group.
  • Handle EdgeNotFoundError and NodeNotFoundError by raising HTTPException with status 404.
  • Update version in pyproject.toml from 0.3.3 to 0.3.4.

This description was created by Ellipsis for cc9eb9f. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 94dc013 in 16 seconds

More details
  • Looked at 43 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. server/graph_service/zep_graphiti.py:48
  • Draft comment:
    Consider handling NodeNotFoundError in addition to EdgeNotFoundError to ensure consistent error handling for nodes.
  • Reason this comment was not posted:
    Confidence changes required: 80%
    The delete_group method in zep_graphiti.py should handle NodeNotFoundError as well, similar to delete_episodic_node, to ensure consistent error handling for nodes.
2. server/graph_service/zep_graphiti.py:47
  • Draft comment:
    Consider handling NodeNotFoundError in addition to EdgeNotFoundError to ensure consistent error handling for nodes.
  • Reason this comment was not posted:
    Confidence changes required: 80%
    The delete_group method in zep_graphiti.py should handle NodeNotFoundError as well, similar to delete_episodic_node, to ensure consistent error handling for nodes.
3. server/graph_service/zep_graphiti.py:36
  • Draft comment:
    Add a comment explaining the purpose and functionality of the delete_group method, as it performs a complex operation involving multiple deletions.
  • Reason this comment was not posted:
    Confidence changes required: 80%
    The method delete_group in zep_graphiti.py is responsible for deleting edges, nodes, and episodes associated with a group. This is a complex operation and should have a comment explaining its purpose and functionality.
4. server/graph_service/routers/ingest.py:93
  • Draft comment:
    Add a comment explaining the purpose and functionality of the delete_group method, as it performs a complex operation involving multiple deletions.
  • Reason this comment was not posted:
    Confidence changes required: 80%
    The method delete_group in zep_graphiti.py is responsible for deleting edges, nodes, and episodes associated with a group. This is a complex operation and should have a comment explaining its purpose and functionality.

Workflow ID: wflow_lOPYt8dr30CTnBEL


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 62b3f5f in 27 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. pyproject.toml:3
  • Draft comment:
    Version bump is appropriate for the new feature addition.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The version bump in the pyproject.toml file is appropriate for a new feature addition.

Workflow ID: wflow_k9yhjDbOMJTY6DeL


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on cc9eb9f in 22 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. server/graph_service/zep_graphiti.py:46
  • Draft comment:
    Consider handling the case where no edges, nodes, or episodes are found for the given group_id to provide feedback if nothing was deleted.
  • Reason this comment was not posted:
    Confidence changes required: 80%
    The delete_group method in ZepGraphiti class should handle the case where no edges, nodes, or episodes are found for the given group_id. This could lead to a situation where the function completes without any indication that nothing was deleted, which might be misleading to the user.
2. server/graph_service/zep_graphiti.py:49
  • Draft comment:
    The exception handling for EdgeNotFoundError and NodeNotFoundError is repetitive. Consider combining them to avoid repetition.
  • Reason this comment was not posted:
    Confidence changes required: 80%
    The delete_group method is handling two exceptions in the same way, which is repetitive. This violates the DRY principle.

Workflow ID: wflow_nbkTqHHFyldnd0vA


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants