Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register pytest test with meson #967

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

picsel2
Copy link
Member

@picsel2 picsel2 commented Apr 8, 2023

This lets us run tests using the build system.
It also makes GNOME Builder display the test in its tests list so we can execute them from there.

@picsel2 picsel2 changed the title Tests/from meson Register pytest test with meson Apr 8, 2023
@nekohayo
Copy link
Member

@SqAtx this is also relevant to your #999 I think?

@nekohayo nekohayo added the maintainability Automated tests suite, tooling, refactoring, or anything that makes it easier for developers label Feb 27, 2024
@picsel2 picsel2 force-pushed the tests/from-meson branch 3 times, most recently from f228e61 to 77631e8 Compare February 29, 2024 22:10
@picsel2 picsel2 marked this pull request as ready for review February 29, 2024 22:39
This allows with pytest to run the tests immediately instead of the
requirement to use `/run-test` wrapper script.
This lets us run tests using the build system. It also makes GNOME
Builder display the test in its tests list.
@SqAtx
Copy link
Contributor

SqAtx commented Mar 2, 2024

Cool! Does this mean we can get rid of the run-tests script?

If yes, could you add a section to the README after "Running the beast" with instructions explaining how to run the tests via Meson? I tried the obvious thing and it didn't work:

~/src/gtg$ meson test

ERROR: No such build data file as '/home/kevin/src/gtg/meson-private/build.dat'.

@SqAtx SqAtx mentioned this pull request Mar 5, 2024
@picsel2
Copy link
Member Author

picsel2 commented Mar 5, 2024

The meson tutorial shows how to build and test with meson.
I found some really outdated instructions inside the docs/ directory.
I think I will update them and point there.

Cool! Does this mean we can get rid of the run-tests script?

I hope so 😄

@diegogangl
Copy link
Contributor

LGTM, merging. Thanks!

@diegogangl diegogangl merged commit bd8028e into getting-things-gnome:master Mar 15, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainability Automated tests suite, tooling, refactoring, or anything that makes it easier for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants