-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added strftime to Date #943
Conversation
Reopening as this was closed in error. |
Hi @APCBoston, thank you for looking into this and sorry for the long development cycle we have been through. Apologies for the inconvenience; the new codebase is expected to be much better to work with. The big refactoring has finally landed (see the pinned 0.7 tracking issue for details)! It might be good to rebase this to the latest |
Actually, this apparently does not conflict with |
How exciting that the megaport is done! I'll do the rebase now. |
Looking at the GH Actions for the repo, it appears that automated unit testing is currently broken? The test failure doesn't appear directly related to the code in this PR. |
Indeed, see also #999 ;) |
Sorry for long delay @APCBoston! This LGTM, it doesn't conflict with anything in the megabranch and it adds some functionality to the Date class. |
Fixes #870
#942 arose during testing but does not appear to be created by/related to this patch (or, for that matter, reproducible)