Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added strftime to Date #943

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Conversation

APCBoston
Copy link
Contributor

Fixes #870
#942 arose during testing but does not appear to be created by/related to this patch (or, for that matter, reproducible)

@APCBoston APCBoston closed this Dec 4, 2022
@APCBoston APCBoston reopened this Dec 14, 2022
@APCBoston
Copy link
Contributor Author

Reopening as this was closed in error.

@nekohayo
Copy link
Member

nekohayo commented Feb 26, 2024

Hi @APCBoston, thank you for looking into this and sorry for the long development cycle we have been through. Apologies for the inconvenience; the new codebase is expected to be much better to work with.

The big refactoring has finally landed (see the pinned 0.7 tracking issue for details)!

It might be good to rebase this to the latest master to facilitate your testing.

@nekohayo
Copy link
Member

Actually, this apparently does not conflict with master (much to my surprise), but it would be good to test with this on top of master to be sure that it all works correctly.

@APCBoston
Copy link
Contributor Author

How exciting that the megaport is done! I'll do the rebase now.

@APCBoston
Copy link
Contributor Author

Looking at the GH Actions for the repo, it appears that automated unit testing is currently broken? The test failure doesn't appear directly related to the code in this PR.

@nekohayo
Copy link
Member

Indeed, see also #999 ;)

@nekohayo nekohayo added the bug label Feb 28, 2024
@diegogangl
Copy link
Contributor

Sorry for long delay @APCBoston! This LGTM, it doesn't conflict with anything in the megabranch and it adds some functionality to the Date class.
Thanks! Merging

@diegogangl diegogangl merged commit 784fa83 into getting-things-gnome:master Mar 22, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants